Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert Signed Releases to probes #3610

Merged
merged 19 commits into from
Dec 13, 2023

Conversation

AdamKorcz
Copy link
Contributor

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)


@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #3610 (2aede14) into main (d03c8cb) will decrease coverage by 5.30%.
The diff coverage is 81.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3610      +/-   ##
==========================================
- Coverage   76.11%   70.81%   -5.30%     
==========================================
  Files         214      216       +2     
  Lines       14797    14962     +165     
==========================================
- Hits        11262    10595     -667     
- Misses       2862     3733     +871     
+ Partials      673      634      -39     

probes/releasesAreSigned/def.yml Show resolved Hide resolved
probes/releasesAreSigned/def.yml Show resolved Hide resolved
probes/releasesAreSigned/def.yml Outdated Show resolved Hide resolved
probes/releasesHaveProvenance/def.yml Show resolved Hide resolved
probes/releasesHaveProvenance/def.yml Outdated Show resolved Hide resolved
probes/releasesAreSigned/def.yml Show resolved Hide resolved
probes/releasesAreSigned/def.yml Show resolved Hide resolved
probes/releasesAreSigned/impl.go Outdated Show resolved Hide resolved
probes/releasesAreSigned/def.yml Show resolved Hide resolved
checks/evaluation/signed_releases.go Outdated Show resolved Hide resolved
probes/releasesAreSigned/def.yml Show resolved Hide resolved
probes/releasesHaveProvenance/impl.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 6, 2023

This pull request is stale because it has been open for 10 days with no activity

@github-actions github-actions bot added the Stale label Nov 6, 2023
@AdamKorcz AdamKorcz force-pushed the signed-releases-probe branch from fe2432f to 8f46e77 Compare November 16, 2023 16:39
@AdamKorcz AdamKorcz requested a review from a team as a code owner November 16, 2023 16:39
@github-actions github-actions bot removed the Stale label Nov 17, 2023
Copy link

This pull request is stale because it has been open for 10 days with no activity

@laurentsimon
Copy link
Contributor

Please lmk when it's ready to merge. I'm fine discarding the comment #3610 (comment)

Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
@AdamKorcz
Copy link
Contributor Author

@laurentsimon The PR should be ready now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants