Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Platform OSTIS 0.10.0 #61

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

NikitaZotov
Copy link
Member

@NikitaZotov NikitaZotov commented Feb 4, 2025

Important

Update codebase to OSTIS Platform 0.10.0 API, including renaming classes, methods, and fixing typos.

  • API Updates:
    • Rename all API classes, methods, and objects to align with OSTIS Platform 0.10.0.
    • Update ScEventParams to ScEventSubscriptionParams and related event handling in ScLangText.tsx and scUtilsBuilder.ts.
    • Change findKeynodes to searchKeynodes in ScUtils.tsx, scUtilsBuilder.ts, and searchKeynodes.ts.
  • Component Changes:
    • Rename question prop to action in Scg.tsx, Scn.tsx, and related components.
    • Update ScType constants in ScnElement.tsx, constants.ts, and mock/scn.ts.
  • Documentation:
    • Fix typos in development-guide.md, git-workflow.md, and release.md.

This description was created by Ellipsis for e4635c1. It will automatically update as commits are pushed.

@NikitaZotov
Copy link
Member Author

@ellipsis, give me a review, please

@NikitaZotov NikitaZotov changed the title Migrate to 0.10.0 Migrate to Platform OSTIS 0.10.0 Feb 4, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e4635c1 in 4 minutes and 0 seconds

More details
  • Looked at 1206 lines of code in 17 files
  • Skipped 2 files when reviewing.
  • Skipped posting 14 drafted comments based on config settings.
1. docs/development-guide.md:5
  • Draft comment:
    Typo: 'vut' should be 'but'.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. docs/development-guide.md:11
  • Draft comment:
    Fix typo: 'lovercased' should be 'lowercased'.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. docs/git-workflow.md:23
  • Draft comment:
    Typo in branch naming: change 'Exemple' to 'Example'.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
4. docs/release.md:15
  • Draft comment:
    Correct spelling: 'begining' should be 'beginning'.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
5. src/components/Language/ScLangText.tsx:54
  • Draft comment:
    Fix typo: 'subscibedAddr' should be 'subscribedAddr' in callback parameter.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. src/components/ScUtils/scUtilsBuilder.ts:126
  • Draft comment:
    Inconsistent usage of event ID: sometimes passing primitive number vs. an object with 'id'. Ensure consistent API usage with destroyElementaryEventSubscriptions.
  • Reason this comment was not posted:
    Marked as duplicate.
7. src/components/Scg/Scg.tsx:113
  • Draft comment:
    Ensure the onUpdateScg callback uses the 'action' prop consistently.
  • Reason this comment was not posted:
    Comment did not seem useful.
8. src/index.tsx:36
  • Draft comment:
    Export updated utility: ensure removal of findKeynodes and export searchKeynodes.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
9. src/components/Language/ScLangText.tsx:54
  • Draft comment:
    Typo: The callback parameter is named 'subscibedAddr' but should be 'subscribedAddr' for clarity.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
10. src/components/ScUtils/scUtilsBuilder.ts:93
  • Draft comment:
    In getResult, the subscription result is handled by destructuring into 'eventId' and then accessing eventId.id. For consistency and clarity, consider destructuring as { id } directly.
  • Reason this comment was not posted:
    Marked as duplicate.
11. src/components/ScUtils/scUtilsBuilder.ts:87
  • Draft comment:
    The helper function 'addrOrSystemIdAddr' uses 'if (numericAddr)' which can misinterpret '0' as false. If 0 is a valid address, use an explicit check (e.g. Number.isNaN) instead.
  • Reason this comment was not posted:
    Comment was on unchanged code.
12. src/utils/searchKeynodes.ts:1
  • Draft comment:
    The import of 'SnakeToCamelCase' from '@model/utils' is unused in this file. Consider removing it to keep the code clean.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
13. src/components/Scg/Scg.tsx:114
  • Draft comment:
    The check 'if (!action)' might incorrectly exclude a valid action value of 0. Use an explicit null/undefined check instead.
  • Reason this comment was not posted:
    Marked as duplicate.
14. package.json:32
  • Draft comment:
    The dependency for 'ts-sc-client' is set to a fixed version '0.5.0'. Confirm that this strict version is intended; using a semver range might offer better compatibility.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_V9QJs2kbHi72VAgR


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -1,12 +1,12 @@
{
"name": "ostis-ui-lib",
"version": "0.0.1-beta.6",
"version": "0.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

010?

renderRequestPanel?: (addr: number) => ReactNode;
onAskQuestion: TOnAskQuestion;
onAskAction: TOnAskAction;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually questions are asked
actions are initiated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants