Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[memory] Update log level for color info log #471

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

kilativ-dotcom
Copy link
Member

@kilativ-dotcom kilativ-dotcom commented Feb 6, 2025


Important

Update SC_LOG_INFO_COLOR macro in sc_logger.hpp to use correct log level enumeration.

  • Macro Update:
    • In sc_logger.hpp, update SC_LOG_INFO_COLOR macro to use utils::ScLogLevel::Level::Info instead of ::utils::ScLogType::Info.

This description was created by Ellipsis for c1ce02b. It will automatically update as commits are pushed.

@kilativ-dotcom kilativ-dotcom self-assigned this Feb 6, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c1ce02b in 25 seconds

More details
  • Looked at 10 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. sc-memory/sc-memory/include/sc-memory/utils/sc_logger.hpp:297
  • Draft comment:
    Good change: SC_LOG_INFO_COLOR now correctly uses 'utils::ScLogLevel::Level::Info' instead of the incorrect '::utils::ScLogType::Info'. This adjustment aligns with the other log macros and ensures that the proper enum is passed to the Message function.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. sc-memory/sc-memory/include/sc-memory/utils/sc_logger.hpp:297
  • Draft comment:
    Good fix: Updated the SC_LOG_INFO_COLOR macro to use ScLogLevel::Level::Info rather than the incorrect ScLogType::Info. This change aligns it with the other log macros.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative, as it simply acknowledges a fix and provides no actionable feedback or suggestions. It does not align with the rules for useful comments, which should provide specific suggestions or highlight potential issues.

Workflow ID: wflow_4k7mfYghayhvTGaB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (dc56d54) to head (01b066e).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   95.74%   95.77%   +0.02%     
==========================================
  Files         237      237              
  Lines       27369    27369              
  Branches     1876     1877       +1     
==========================================
+ Hits        26205    26212       +7     
+ Misses       1164     1157       -7     

Copy link
Member

@NikitaZotov NikitaZotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update changelog

@kilativ-dotcom kilativ-dotcom merged commit ad90ff9 into main Feb 12, 2025
15 checks passed
@kilativ-dotcom kilativ-dotcom deleted the kilativ-dotcom-patch-1 branch February 12, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants