Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Add dependency between changelog and build-conan ci #38

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

NikitaZotov
Copy link
Member

@NikitaZotov NikitaZotov commented Jan 31, 2025


Important

Add dependency between changelog and build-conan jobs in release.yml.

  • CI/CD:
    • Add needs: build-conan to changelog job in release.yml to ensure it runs after build-conan.

This description was created by Ellipsis for 4f63a50. It will automatically update as commits are pushed.

@NikitaZotov NikitaZotov self-assigned this Jan 31, 2025
@NikitaZotov NikitaZotov added bug Something isn't working 0.1.0 labels Jan 31, 2025
@NikitaZotov NikitaZotov added this to the 0.1.0 milestone Jan 31, 2025
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 4f63a50 in 9 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. .github/workflows/release.yml:98
  • Draft comment:
    The addition of needs: build-conan is correct and ensures the changelog job runs after the build-conan job, maintaining the logical flow of the CI process.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The addition of 'needs: build-conan' in the changelog job ensures that the changelog job will only run after the build-conan job is completed. This is a logical dependency since the changelog might need information from the build artifacts.
2. .github/workflows/release.yml:98
  • Draft comment:
    The addition of needs: build-conan correctly establishes a dependency between the changelog and build-conan jobs, ensuring that the changelog job only runs after build-conan completes.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The changelog job now depends on the build-conan job, which is a logical dependency. This change is appropriate and does not violate any of the specified rules.

Workflow ID: wflow_tsETBwqoCnKCb6OI


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NikitaZotov NikitaZotov merged commit 69b1a9e into ostis-ai:main Jan 31, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.1.0 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant