work around disagreement with pyright & reorder-python-imports

app/state/services.py

@@ -12,6 +12,7 @@
 from typing import Mapping
 from typing import MutableMapping
 from typing import Optional
+from typing import TYPE_CHECKING
 
 import aiohttp
 import aioredis
@@ -27,6 +28,16 @@
 from app.logging import ansi_rgb_rainbow
 
 
+if TYPE_CHECKING:
+    # XXX: reorder-python-imports removes redundant imports, meaning that the
+    # import of `databases.core` also imports databases. pyright however, does
+    # not support this behaviour and thus breaks the types from the parent module.
+    # sadly, neither party wishes to back down - we do this to work around this issue.
+    # https://github.com/asottile/reorder_python_imports/issues/221
+    # https://github.com/microsoft/pyright/issues/2964
+    import databases
+
+
 STRANGE_LOG_DIR = Path.cwd() / ".data/logs"
 GEOLOC_DB_FILE = Path.cwd() / "ext/GeoLite2-City.mmdb"