Certgen & QOL changes #19
Conversation
|
Hey, there seems to be some sort of difference in the format from this cert to akatsuki/ripple/etc.. i think this may be the same as the ainu certificate, which seems to work.. sometimes? lol once i figure out the differences, i might add a certgen (but i'm also not sure about how the osu team will feel about it xd) |
|
Hey, it's been a while, but if you'd like to PR the certgen into (Generally we suggest prod users to use cloudflare flex to sidestep tls entirely on the server-side) |
|
one point for that pr if you go through with it - |
Wouldn't it be better to use mkcert for localhost certs? |
i agree, mkcert has had a more intuitive process for me |
Perhaps - I had some issues with generating one for local dev (perhaps an issue with my usage), and have always fallen back to using openssl directly. If you'd like to propose a PR for it, I'm open to the best suggestion! |
|
Might also be useful to include a small document to define the process of setting up a local server, including hosts file redirection and such. Could be a separate PR or together as one. |
|
I was thinking of adding it also in #320 but wouldn't the README be too bloated? I think the best thing would be to move some of those instructions to github wiki |
|
I've spoken with Jackson and he is open to fixing this PR up. (I think documentation should be a separate PR btw since translations and such) |
Keep PRs small and specific, this PR is already a bit large for my liking (e.g. I think we could have split up the ssl removal & and the docker setup, and reviewed those separately). Big PRs are much more difficult to keep up to date while master is worked on, and also harder to review. I've had to learn this lesson multiple times, the hard way, because I couldn't merge my changes anymore as it was far too much work; some examples:
I've found much more success in breaking down a large task into smaller subcomponents; a good example is my recent work on refactoring SQL queries into repositories;
Work is also much more parallelizable this way - if you have a large chunk of work that you've successfully split up (like this), multiple people can work on it at the same time (@yo-ru has been helping me out!). |
|
I would disagree with renaming ext to external |
There is no point in reviewing a PR from 2020 (ext did not exist back then) |
Up to you if you want to merge this. Certgen was working last time I used it which was about a month ago :)