Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tekst TV 3.0 desking #117

Merged
merged 25 commits into from
Oct 15, 2024
Merged

Add Tekst TV 3.0 desking #117

merged 25 commits into from
Oct 15, 2024

Conversation

rmens
Copy link
Contributor

@rmens rmens commented Jul 21, 2024 •
edited
Loading

  • Adds desking options for tekst tv
  • Clean-up of desking options

@rmens rmens closed this Jul 21, 2024
@rmens rmens deleted the desking-update branch July 21, 2024 15:46
@rmens rmens restored the desking-update branch July 21, 2024 15:46
@rmens rmens reopened this Jul 21, 2024
@rmens rmens force-pushed the desking-update branch 3 times, most recently from 2c21b43 to 71ce53f Compare July 21, 2024 18:28
@rmens rmens requested a review from marijnvdwerf July 21, 2024 18:35
@rmens
Copy link
Contributor Author

rmens commented Jul 21, 2024

Changes live on preview.

rmens and others added 2 commits August 3, 2024 00:58
@rmens
Update desking branch (#119)
e596d4f 
* Update VideoJS
* Add `post_kabelkrant_content_gpt` field (#118)
* Bump version
* Remove hotfix
@rmens
Update package-lock.json
6530d23
@rmens
Copy link
Contributor Author

rmens commented Aug 16, 2024

Als er geen TV-week is aangemaakt. We missen een if'je denk ik.

<br />
<b>Warning</b>:  foreach() argument must be of type array|object, bool given in <b>/usr/www/users/tvvkra/wordpress/wp-content/themes/streekomroep-wp-desking-update/src/BroadcastSchedule.php</b> on line <b>24</b><br />
<br />
<b>Warning</b>:  Cannot modify header information - headers already sent by (output started at /usr/www/users/tvvkra/wordpress/wp-content/themes/streekomroep-wp-desking-update/src/BroadcastSchedule.php:24) in <b>/usr/www/users/tvvkra/wordpress/wp-includes/rest-api/class-wp-rest-server.php</b> on line <b>1831</b><br />

@marijnvdwerf
Copy link
Collaborator

Waarom zit teksttv in dezelfde fieldset als de voorpagina? Is het idee niet juist om teksttv meer richting 'plugin' te schuiven?

@rmens
Copy link
Contributor Author

rmens commented Aug 17, 2024

Waarom zit teksttv in dezelfde fieldset als de voorpagina? Is het idee niet juist om teksttv meer richting 'plugin' te schuiven?

Kan ook. Ik dacht "dit is desking, we hebben al desking" dus ik frot het erbij.

@rmens rmens force-pushed the desking-update branch 6 times, most recently from 0e0bd3a to b7a831d Compare August 20, 2024 22:34
@rmens
Copy link
Contributor Author

rmens commented Aug 22, 2024

Los van desking getrokken. Dit zou in theorie naar een plug-in kunnen.

@rmens
Copy link
Contributor Author

rmens commented Aug 24, 2024

Checken of broadcast_data api niet kapot is. Spoiler; dat is hij.

@rmens rmens force-pushed the main branch 8 times, most recently from 8594223 to 8818e3c Compare August 24, 2024 21:19
@rmens rmens merged commit e13b12d into main Oct 15, 2024
3 checks passed
@rmens rmens deleted the desking-update branch October 15, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marijnvdwerf marijnvdwerf Awaiting requested review from marijnvdwerf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmens @marijnvdwerf