Guard against closing the same pid twice

oven-sh · Nov 9, 2022 · 8bc459b · 8bc459b
1 parent 5c312ec
commit 8bc459b
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/bun.js/api/bun/subprocess.zig b/src/bun.js/api/bun/subprocess.zig
@@ -297,10 +297,17 @@ pub const Subprocess = struct {
     }
 
     pub fn closePorts(this: *Subprocess) void {
+        const pidfd = this.pidfd;
+
         if (comptime Environment.isLinux) {
-            if (this.pidfd != std.math.maxInt(std.os.fd_t)) {
-                _ = std.os.close(this.pidfd);
-                this.pidfd = std.math.maxInt(std.os.fd_t);
+            this.pidfd = std.math.maxInt(std.os.fd_t);
+        }
+
+        defer {
+            if (comptime Environment.isLinux) {
+                if (pidfd != std.math.maxInt(std.os.fd_t)) {
+                    _ = std.os.close(pidfd);
+                }
             }
         }