Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate from setup.py/setuptools to pyproject.toml/hatch #57

Open
wants to merge 3 commits into
base: release
Choose a base branch
from

Conversation

Danyal-Faheem
Copy link

Comment on lines +36 to +37
"pylint",
"black"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not in setup.py. Are they needed here?

Copy link
Author

@Danyal-Faheem Danyal-Faheem Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were added so that the command make test works as expected to run normal tests since it requires both pylint and black. Previously, one had to install these themselves when working with minio codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants