Merge pull request #873 from daleglass-overte/warnings-as-errors-msvc

Fix warnings as errors for MSVC
overte-org · Mar 16, 2024 · 854d80a · 854d80a
2 parents 3d5afbd + 40761fb
commit 854d80a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -184,8 +184,13 @@ if(OVERTE_WARNINGS_WHITELIST)
 endif()
 
 if(OVERTE_WARNINGS_AS_ERRORS)
-    set(ENV{CXXFLAGS} "$ENV{CXXFLAGS} -Werror")
-    set(ENV{CFLAGS} "$ENV{CXXFLAGS} -Werror")
+    if (CMAKE_CXX_COMPILER_ID MATCHES "MSVC" OR (CMAKE_CXX_COMPILER_ID MATCHES "" AND WIN32))
+      set(ENV{CXXFLAGS} "$ENV{CXXFLAGS} /WX")
+      set(ENV{CFLAGS} "$ENV{CXXFLAGS} /WX")
+    else()
+      set(ENV{CXXFLAGS} "$ENV{CXXFLAGS} -Werror")
+      set(ENV{CFLAGS} "$ENV{CXXFLAGS} -Werror")
+    endif()
 endif()