Update GitHub Actions #1281
Merged
Update GitHub Actions #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGro
added
needs CR
daleglass
approved these changes
Dec 28, 2024
| elif [ "${{ matrix.os }}" == "fedora-38" ]; then | ||
| echo "ARTIFACT_PATTERN=overte-server-$RPMVERSION-1.fc38.$INSTALLER_EXT" >> $GITHUB_ENV | ||
| elif [ "${{ matrix.os }}" == "fedora-39" ]; then | ||
| echo "ARTIFACT_PATTERN=overte-server-$RPMVERSION-1.fc39.$INSTALLER_EXT" >> $GITHUB_ENV |
There was a problem hiding this comment.
We're up to Fedora 41 already
There was a problem hiding this comment.
Yeah, I actually tried adding Fedora 41, but our Node version doesn't build on it, seemingly because they don't package distutils anymore.
There was a problem hiding this comment.
What distutils do you mean?
There was a problem hiding this comment.
It's a deprecated part of the default Python library. It's supposed to still be part of Python 3.11, but even having only Python 3.11 installed in a Fedora 41 container, the library is still missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bunch of deprecation warnings, as well as updating a few things.
It also includes the additional dependencies needed for building the Vulkan version of Interface.