Implement network serializer (rebased) #1293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids warning due to glm::vec3 not being trivially copyable
Single class wasn't working well because deserialization may need to be done on const data. With the split, the deserializer part can work with const data without issues. Also cleaned things up a bit.
* Stop trying to be compatible with the old format, and just bump the version number. * Add uint64_t support to serializer * A bit improved debug output from serializer * Add lastAdvance() function to ask the serializer how much data was added/read in the last operation.
This fixes compatibility with older baked assets
HifiExperiments
added
needs CR
This was referenced Jan 12, 2025
daleglass
approved these changes
Jan 13, 2025
|
sorry I hadn’t tried building the branch myself earlier! if I’d known there was still a bug I would have taken a closer look at things sooner |
|
Awesome! |
ksuprynowicz
added
QA approved
ksuprynowicz
added
the
CR approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81 rebased + with one final bug fix