glTF importer using cgltf library #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksuprynowicz
added
bug
daleglass
requested changes
Feb 25, 2024
daleglass
approved these changes
Feb 25, 2024
ksuprynowicz
added
CR approved
| @@ -20,5 +20,6 @@ hfm::Model::Pointer ModelLoader::load(const hifi::ByteArray& data, const hifi::V | |||
| if (!serializer) { | |||
| return hfm::Model::Pointer(); | |||
| } | |||
| qDebug() << "ModelLoader::load: " << url; | |||
There was a problem hiding this comment.
near the end, hifi tried to remove all instances of directly printing model URLs from the logs as a basic security measure, so I would vote for removing this or just commenting it out
There was a problem hiding this comment.
Thanks! That was indeed intended to be removed and I forgot. What do you think about urls in error messages? Maybe for broken models it would make sense to log url?
There was a problem hiding this comment.
yeah I think in error messages it's helpful, I believe hifi left some of those around too
| hfmModel.loadErrorCount++; | ||
| continue; | ||
| return false; |
There was a problem hiding this comment.
we used to continue here but now we completely bail. is there a reason for that? there are several other places like this above and below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue with ReadyPlayerMe avatars being broken and a lot of other glTF-related issues.