-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ covid mdims review and maintenance #3814
Draft
lucasrodes
wants to merge
15
commits into
master
Choose a base branch
from
enhance-covid-mdims-maintenance-c6c2c9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasrodes
changed the title
✨ covid mdims maintenance
✨ covid mdims review and maintenance
Jan 9, 2025
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ✅ No differences foundLegend: +New ~Modified -Removed =Identical Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2025-01-09 10:43:40 UTC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue work from https://github.com/owid/owid-issues/issues/1659, and #3489.
To finalize the work on MDIMs for COVID, we depend on issues owid/owid-grapher#4040. For now, we are happy if we can bring this to a good resting state, and resume later once this issue is solved.
At the moment, the config is not being propagated, which is a blocker for any progress here.
Goal
Bring COVID MDIMs to a suitable resting state.
What's the status?
Some of the charts still need to be prepared and need modifications. These modifications can be done by editing the MDIM config (or indicator configs) in ETL, including adjusting display settings. Some notes on these:
etlr ... --export
one would expect that the MDIM page reflects config changes. Unfortunately, this takes a while (>10 minutes).MDIM pages
covid.cases
covid.deaths
covid.hospital
covid.boosters
covid.xm
covid.models
covid.cases_tests
covid.covax
covid.vax_breakdowns
covid.xm_models
Q&A: