🔨 cleanup

owid · Jan 29, 2025 · 46f4507 · 46f4507
1 parent 04683c5
commit 46f4507
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/adminSiteClient/AdminApp.tsx b/adminSiteClient/AdminApp.tsx
@@ -340,11 +340,7 @@ export class AdminApp extends React.Component<{
                             />
                             <Route
                                 path="/dataInsights"
-                                component={() => (
-                                    <GdocsStoreProvider>
-                                        <DataInsightIndexPage />
-                                    </GdocsStoreProvider>
-                                )}
+                                component={DataInsightIndexPage}
                             />
                             <Route
                                 exact

diff --git a/adminSiteClient/DataInsightIndexPage.tsx b/adminSiteClient/DataInsightIndexPage.tsx
@@ -245,7 +245,7 @@ export function DataInsightIndexPage() {
                         dataInsight.published &&
                         dayjs(dataInsight.publishedAt).isBefore(dayjs())
                     )
-                default:
+                case "all":
                     return true
             }
         }
@@ -369,7 +369,7 @@ function DataInsightGallery({
         <Flex wrap gap="large">
             {dataInsightsWithPreviewImage.map((dataInsight, index) => (
                 <DataInsightCard
-                    key={`${dataInsight.id}-${index}`}
+                    key={dataInsight.id}
                     dataInsight={dataInsight}
                 />
             ))}
@@ -391,7 +391,7 @@ function DataInsightCard({
     )
 
     return (
-        <Card key={dataInsight.id} cover={preview}>
+        <Card cover={preview}>
             <a
                 href={makePreviewLink(dataInsight)}
                 target="_blank"

diff --git a/adminSiteClient/gdocsValidation.ts b/adminSiteClient/gdocsValidation.ts
@@ -190,7 +190,7 @@ function validateGrapherUrl(
     gdoc: OwidGdocDataInsightInterface,
     errors: OwidGdocErrorMessage[]
 ) {
-    const grapherUrl = gdoc.content["grapher-url"]
+    const grapherUrl = gdoc.content["grapher-url"]?.trim()
     if (grapherUrl) {
         const validPrefixes = [
             "https://ourworldindata.org/grapher/",