✅ fix homepage-into roundtrip test

owid · Feb 13, 2025 · 4a4850c · 4a4850c
1 parent dfa97e9
commit 4a4850c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/db/model/Gdoc/enrichedToRaw.ts b/db/model/Gdoc/enrichedToRaw.ts
@@ -50,6 +50,7 @@ import {
     RawBlockPerson,
     RawBlockNarrativeChart,
     RawBlockCode,
+    RawBlockHomepageIntroPost,
 } from "@ourworldindata/types"
 import { spanToHtmlString } from "./gdocUtils.js"
 import { match, P } from "ts-pattern"
@@ -593,9 +594,7 @@ export function enrichedBlockToRawBlock(
                             type,
                             value: {
                                 ...value,
-                                isNew: value.isNew
-                                    ? value.isNew.toString()
-                                    : "false",
+                                isNew: String(value.isNew),
                                 authors: authors?.join(", "),
                             },
                         })

diff --git a/db/model/Gdoc/exampleEnrichedBlocks.ts b/db/model/Gdoc/exampleEnrichedBlocks.ts
@@ -715,6 +715,7 @@ export const enrichedBlockExamples: Record<
                 kicker: "Article - 10 Mins",
                 filename: "optimism-and-pessimism.jpg",
                 authors: ["Our World In Data"],
+                isNew: false,
             },
             {
                 type: "secondary",
@@ -725,6 +726,7 @@ export const enrichedBlockExamples: Record<
                 kicker: "Article - 10 Mins",
                 filename: "optimism-and-pessimism.jpg",
                 authors: ["Our World In Data"],
+                isNew: true,
             },
             {
                 type: "secondary",
@@ -734,20 +736,23 @@ export const enrichedBlockExamples: Record<
                 kicker: "Article - 10 Mins",
                 filename: "featured-image.jpg",
                 authors: ["Max Roser"],
+                isNew: false,
             },
             {
                 type: "tertiary",
                 url: "https://ourworldindata.org/front-end-engineer",
                 title: "We’re looking for a front-end engineer to join our team.",
                 kicker: "Announcement",
                 authors: ["Our World In Data"],
+                isNew: false,
             },
             {
                 type: "tertiary",
                 url: "https://ourworldindata.org/civil-engineer",
                 title: "We’re looking to build bridges with a civil engineer.",
                 kicker: "Announcement",
                 authors: ["Our World In Data"],
+                isNew: false,
             },
         ],
         parseErrors: [],

diff --git a/db/model/Gdoc/rawToArchie.ts b/db/model/Gdoc/rawToArchie.ts
@@ -825,6 +825,7 @@ function* rawBlockHomepageIntroToArchieMLString(
             yield* propertyToArchieMLString("filename", value)
             yield* propertyToArchieMLString("kicker", value)
             yield* propertyToArchieMLString("authors", value)
+            yield* propertyToArchieMLString("isNew", value)
             yield "{}"
         }
     }