refactor: use a type union for OwidProcessingLevel

owid · Oct 30, 2023 · 615f0c0 · 615f0c0
1 parent 0599d5f
commit 615f0c0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/datapage/Datapage.ts b/datapage/Datapage.ts
@@ -30,7 +30,7 @@ export const getDatapageDataV2 = async (
 ): Promise<DataPageDataV2> => {
     {
         const processingLevel =
-            variableMetadata.processingLevel ?? OwidProcessingLevel.minor
+            variableMetadata.processingLevel ?? "minor"
         const lastUpdated = getLastUpdatedFromVariable(variableMetadata) ?? ""
         const nextUpdate = getNextUpdateFromVariable(variableMetadata)
         const datapageJson: DataPageDataV2 = {

diff --git a/packages/@ourworldindata/components/src/IndicatorKeyData/IndicatorKeyData.tsx b/packages/@ourworldindata/components/src/IndicatorKeyData/IndicatorKeyData.tsx
@@ -19,7 +19,7 @@ interface IndicatorKeyDataProps {
 export const IndicatorKeyData = (props: IndicatorKeyDataProps) => {
     const canonicalUrl = props.canonicalUrl ?? ""
     const processedAdapted = getPhraseForProcessingLevel(
-        props.owidProcessingLevel ?? OwidProcessingLevel.minor
+        props.owidProcessingLevel ?? "minor"
     )
     const dateRange = getDateRange(props.dateRange)
     const lastUpdated = dayjs(props.lastUpdated, ["YYYY", "YYYY-MM-DD"])

diff --git a/packages/@ourworldindata/utils/src/OwidVariable.ts b/packages/@ourworldindata/utils/src/OwidVariable.ts
@@ -100,10 +100,7 @@ export interface OwidVariablePresentation {
     faqs?: FaqLink[]
 }
 
-export enum OwidProcessingLevel {
-    minor = "minor",
-    major = "major",
-}
+export type OwidProcessingLevel = 'minor' | 'major'
 
 export interface FaqLink {
     gdocId: string

diff --git a/packages/@ourworldindata/utils/src/index.ts b/packages/@ourworldindata/utils/src/index.ts
@@ -497,7 +497,7 @@ export {
     type OwidVariablePresentation,
     type OwidEntityKey,
     type OwidLicense,
-    OwidProcessingLevel,
+    type OwidProcessingLevel,
 } from "./OwidVariable.js"
 
 export {