🐛 don't render tags section in datapage header if no tags are present…

… after filtering
owid · Feb 5, 2025 · e6bd9b4 · e6bd9b4
1 parent 4ac3177
commit e6bd9b4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/site/DataPageV2Content.tsx b/site/DataPageV2Content.tsx
@@ -115,13 +115,11 @@ export const DataPageV2Content = ({
                                     {titleFragments}
                                 </div>
                             </div>
-                            {!!datapageData.topicTagsLinks?.length && (
-                                <TopicTags
-                                    className="header__right col-start-10 span-cols-4 col-sm-start-2 span-sm-cols-12"
-                                    topicTagsLinks={datapageData.topicTagsLinks}
-                                    tagToSlugMap={tagToSlugMap}
-                                />
-                            )}
+                            <TopicTags
+                                className="header__right col-start-10 span-cols-4 col-sm-start-2 span-sm-cols-12"
+                                topicTagsLinks={datapageData.topicTagsLinks}
+                                tagToSlugMap={tagToSlugMap}
+                            />
                         </div>
                     </div>
                     <nav className="sticky-nav sticky-nav--dark span-cols-14 grid grid-cols-12-full-width">

diff --git a/site/TopicTags.tsx b/site/TopicTags.tsx
@@ -4,13 +4,15 @@ export default function TopicTags({
     tagToSlugMap,
 }: {
     className?: string
-    topicTagsLinks: string[]
+    topicTagsLinks?: string[]
     tagToSlugMap: Record<string, string>
 }) {
     // TODO (DB): mark topic pages
     const tags = topicTagsLinks
         ?.map((name) => ({ name, slug: tagToSlugMap[name] }))
         .filter((tag) => !!tag.slug)
+    if (!tags?.length) return null
+
     return (
         <div className={className}>
             <div className="topic-tags__label">