Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart pageviews not showing in dataset and tag pages #4521

Closed
lucasrodes opened this issue Feb 4, 2025 · 0 comments · Fixed by #4533
Closed

Chart pageviews not showing in dataset and tag pages #4521

lucasrodes opened this issue Feb 4, 2025 · 0 comments · Fixed by #4533
Assignees
@marcelgerber
Labels
admin Issues that need to be solved in the grapher admin (mostly) bug priority 3 - nice to have site soonish and small Do it some time soon like next cooldown viz

Comments

@lucasrodes
Copy link
Member

lucasrodes commented Feb 4, 2025 •
edited
Loading

Description

We recently started showing the chart views in Admin. These views are visible from the chart admin page. However, they are not visible from the Dataset or Tag admin pages, where we also show a table with relevant charts.

Expected behaviour

Chart views should be shown also in Dataset and Tag admin pages.

Steps to reproduce

Example pages not showing chart views:

Screenshots

Image

Additional context

Related discussions on Slack:
@marcelgerber marcelgerber added viz admin Issues that need to be solved in the grapher admin (mostly) labels Feb 4, 2025
@rakyi rakyi added the site label Feb 4, 2025
@marcelgerber marcelgerber changed the title Chart views not showing in dataset and tag pages Chart pageviews not showing in dataset and tag pages Feb 5, 2025
@danyx23 danyx23 added soonish and small Do it some time soon like next cooldown priority 3 - nice to have and removed needs triage labels Feb 5, 2025
@marcelgerber marcelgerber mentioned this issue Feb 6, 2025
Merged
@marcelgerber marcelgerber self-assigned this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcelgerber marcelgerber

Labels
admin Issues that need to be solved in the grapher admin (mostly) bug priority 3 - nice to have site soonish and small Do it some time soon like next cooldown viz
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(admin): bring feature parity to all uses of ChartList component owid/owid-grapher
4 participants
@marcelgerber @danyx23 @rakyi @lucasrodes