Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): bring feature parity to all uses of ChartList component #4533

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Feb 6, 2025

Fixes #4521 by including pageviewsPerDay in the 3 relevant queries for dataset, variable, and tag pages.

Also improves the 3 uses of ChartList (in dataset, variable, and tag pages) insofar that one can now also search these lists.

The split between ChartIndexPage and ChartList is now as follows: ChartIndexPage only needs to take care of data loading, and then passes a complete, unfiltered list of charts to <ChartList>.
It then takes care of sorting, filtering, basic pagination (via "Show more charts"), and handling the ?chartSearch= query param.

@marcelgerber marcelgerber requested review from danyx23 and sophiamersmann and removed request for danyx23 February 6, 2025 10:15
@marcelgerber marcelgerber marked this pull request as ready for review February 6, 2025 10:15
@owidbot
Copy link
Contributor

owidbot commented Feb 6, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-chart-pageviews-tags-dataset

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-02-06 10:25:43 UTC
Execution time: 1.29 seconds

Copy link
Member

@sophiamersmann sophiamersmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@marcelgerber marcelgerber merged commit 15bc34e into master Feb 6, 2025
38 checks passed
@marcelgerber marcelgerber deleted the chart-pageviews-tags-datasets branch February 6, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chart pageviews not showing in dataset and tag pages
3 participants