feat(admin): bring feature parity to all uses of ChartList
component
#4533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4521 by including
pageviewsPerDay
in the 3 relevant queries for dataset, variable, and tag pages.Also improves the 3 uses of
ChartList
(in dataset, variable, and tag pages) insofar that one can now also search these lists.The split between
ChartIndexPage
andChartList
is now as follows: ChartIndexPage only needs to take care of data loading, and then passes a complete, unfiltered list of charts to<ChartList>
.It then takes care of sorting, filtering, basic pagination (via "Show more charts"), and handling the
?chartSearch=
query param.