Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(grapher): remove missing data strategy for (stacked) discrete bar charts #2837

Conversation

sophiamersmann
Copy link
Member

  • The transforms functions that apply the missing data strategy to DiscreteBar charts and StackedDiscreteBar charts are buggy
  • Luckily, none of our DiscreteBar/StackedDiscreteBar charts in the live db currently use the missing data strategy option (maybe a sign?!)
  • As a hot fix, I simply remove the data missing strategy option for these chart types
  • We might add them back in the future (or maybe not, cause apparently no-one has used these options for months)
  • But we might want to make Grapher a bit smarter when it comes to missing data (I'll elaborate elsewhere)

@sophiamersmann sophiamersmann merged commit 90b6cef into master Oct 24, 2023
@sophiamersmann sophiamersmann deleted the hotfix-remove-missing-data-strategy-for-discrete-bar-charts branch October 24, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant