✨ (entity selector) remove slide-in settings drawer

[sophiamersmann]

Cycle 2024.2: Entity selector (prep work)

Removes the slide-in settings drawer and always renders settings into a popup instead.

We will be using the slide-in drawer for the entity selector instead (at certain screen sizes). I removed the slide-in drawer code in this PR, but I will be re-adding it for the entity selector in subsequent PRs.

[sophiamersmann]

• ✨ (entity selector) remove slide-in settings drawer #3353 : 3 dependent PRs (#3356 , #3363 , #3373 ) 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite

[marcelgerber]

Looks and works great, thank you!

[coderabbitai]

Walkthrough

The recent updates across various files in the Our World in Data Grapher codebase mainly focus on refining the user interface, specifically transitioning from a drawer to a popup model for settings and map projections. This involved adjustments in z-index values for proper layering, simplification of toggle and visibility logic in the settings menu, and the removal of constants and references associated with the previous drawer implementation. These changes aim to streamline the user experience and code efficiency.

Changes

Files	Summary
.../MapProjectionMenu.scss, .../SettingsMenu.scss, .../core/grapher.scss	Updated z-index values to $zindex-controls-popup and restructured styling for better UI layering.
.../SettingsMenu.tsx	Simplified the settings menu by refining visibility logic, removing unused properties, and enhancing animation and layout handling.
.../GrapherConstants.ts, .../index.ts, .../FullScreen.tsx, site/DataPageV2.tsx, site/ExplorerPage.tsx, site/GrapherPage.tsx	Removed references and exports of GRAPHER_SETTINGS_DRAWER_ID, adjusting logic and imports accordingly.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sophiamersmann]

Merge activity

• May 3, 4:04 AM EDT: @sophiamersmann started a stack merge that includes this pull request via Graphite.
• May 3, 4:05 AM EDT: @sophiamersmann merged this pull request with Graphite.