🔨 set up eslint rule to error on dangling promises + fix 245 violations

[danyx23]

With the introduction of a more rigorous use of transactions, dangling promises have become more problematic. It used to the be the case that if a promise was not awaited in an api route handler, node would just wait for it to complete. But since we now open transaction scopes in the route handlers, it can happen that a the router handler finishes and closes a transaction and then the dangling promise continues and tries to access the db via that transaction which then leads to an error and crashes the admin.

This PR enables an ESLint rule that makes unhandled promises an error. You can either await the result, or, for cases where you genuinely do not need to await the promise, mark the promise as intentionally not awaited by prefixing it with the JS void operator.

This PR then fixes all the ~250 places that this eslint rule complained about

[danyx23]

• 🔨 refactor suggested chart revision tool to use knex #3396
• Fix remaining refactor issues #3391
• 🔨 images need a RW transaction in case they need to update the db 😢 - bubble this up #3385
• ✨ unify transaction creation and close db connection in same call for scripts #3360
• 🔨 switch almost all remaining typeorm util function holdouts to knex #3359
• 🔨 set up eslint rule to error on dangling promises + fix 245 violations #3358 👈
• 🚧 remove typeorm annotations from GDocs classes #3299 : 1 other dependent PR (#3372 )
• 🐝 remove obsolete code #3298
• 🔨 migrate charts from typeorm to knex #3293
• 🔨 clean up posts access via knex #3292
• ✨ add transaction types and api route helpers #3271
• 🔨 migrate PostLink to knex #3259
• 💄 reorder parameters of knexRaw and knexRawFirst to have knex in first pos #3258
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @danyx23 and the rest of your teammates on Graphite

[danyx23]

Merge activity

• Mar 26, 10:04 AM EDT: @danyx23 started a stack merge that includes this pull request via Graphite.
• Mar 26, 10:19 AM EDT: Graphite rebased this pull request as part of a merge.
• Mar 26, 10:22 AM EDT: @danyx23 merged this pull request with Graphite.