Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: API handlers for narrative views #4201

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Nov 21, 2024

Part of #4128.

This PR creates the DB table needed for narrative views, and sets up some CRUD methods for these that handle generating patch configs, explicitly persisting some properties of the patch, storing them in the DB and R2, and so on.

@marcelgerber marcelgerber requested a review from danyx23 November 21, 2024 14:57
@marcelgerber marcelgerber marked this pull request as ready for review November 21, 2024 14:57
@owidbot
Copy link
Contributor

owidbot commented Nov 21, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-narrative-views-api

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-21 15:03:36 UTC
Execution time: 1.29 seconds

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marcelgerber marcelgerber merged commit e412a5f into master Nov 22, 2024
21 checks passed
@marcelgerber marcelgerber deleted the narrative-views-api branch November 22, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants