✨ Extract grapher state from the react component [3/4] #4378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyx23
force-pushed
the
extract-grapher-state
branch
from
cb9c71a to
8a627e2
Compare
danyx23
force-pushed
the
extract-grapher-loading
branch
from
29148e1 to
8efa117
Compare
danyx23
changed the base branch from
extract-grapher-loading
to
reorder-grapher-props
danyx23
force-pushed
the
extract-grapher-state
branch
2 times, most recently
from
cc0b8c2 to
338a5ed
Compare
danyx23
force-pushed
the
reorder-grapher-props
branch
from
a651424 to
ca4adc4
Compare
danyx23
force-pushed
the
extract-grapher-state
branch
from
338a5ed to
01f280a
Compare
danyx23
force-pushed
the
reorder-grapher-props
branch
from
ca4adc4 to
3d99edc
Compare
danyx23
force-pushed
the
extract-grapher-state
branch
from
01f280a to
70ad31c
Compare
danyx23
force-pushed
the
reorder-grapher-props
branch
from
3d99edc to
176b57f
Compare
danyx23
force-pushed
the
extract-grapher-state
branch
from
70ad31c to
2348bca
Compare
danyx23
force-pushed
the
reorder-grapher-props
branch
from
13c6dc0 to
cf5a498
Compare
danyx23
force-pushed
the
extract-grapher-state
branch
2 times, most recently
from
e22a5b5 to
d4e1269
Compare
danyx23
force-pushed
the
reorder-grapher-props
branch
from
45b3971 to
d480739
Compare
danyx23
force-pushed
the
extract-grapher-state
branch
from
d4e1269 to
530ed25
Compare
danyx23
force-pushed
the
extract-grapher-state
branch
from
530ed25 to
f97f5e8
Compare
danyx23
force-pushed
the
reorder-grapher-props
branch
from
d480739 to
1af440f
Compare
danyx23
force-pushed
the
reorder-grapher-props
branch
from
1af440f to
5be0919
Compare
danyx23
force-pushed
the
extract-grapher-state
branch
2 times, most recently
from
954bcac to
f859fe0
Compare
danyx23
force-pushed
the
reorder-grapher-props
branch
from
5be0919 to
487953b
Compare
danyx23
force-pushed
the
reorder-grapher-props
branch
from
487953b to
b74b2e8
Compare
danyx23
force-pushed
the
extract-grapher-state
branch
from
f859fe0 to
ab5227e
Compare
marcelgerber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a part of a stack and not intended to be merged on it's own or maybe even reviewed on it's own. The tests fail on this and Grapher does not in most places load it's data anymore.
This is the first of two big PRs - this one moves almost all Grapher observables and computed props into the new
GrapherStateclass. It doesn't fix the usage sites yet so while the lerna packages compile, the rest of the typescript projects (admin, site, ...) don't.I'm not sure if this PR can be reasonably reviewed on it's own or if the entire stack should be looked at in one go.