Add eslint-plugin-react-refresh #4379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rakyi
force-pushed
the
eslint-plugin-react-refresh
branch
from
34d7006 to
4d3ea4a
Compare
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-03 17:16:51 UTC |
rakyi
force-pushed
the
eslint-plugin-react-refresh
branch
from
4d3ea4a to
4968f76
Compare
rakyi
force-pushed
the
eslint-plugin-react-refresh
branch
from
4968f76 to
16df04b
Compare
danyx23
approved these changes
Jan 6, 2025
Fast Refresh is a feature that lets you edit React components in a running application without losing their state. It is similar to an old feature known as "hot reloading", but Fast Refresh is more reliable and officially supported by React. Vite already supports Fast Refresh, but it works only under specific conditions. This ESlint plugin helps us write components in a way that ensures they can be reloaded using Fast Refresh. We don't enable it for directories containing mostly class components, since it doesn't work for them. As part of this change I fixed the linter errors by refactoring the code, which means now many more components will be working with Fast Refresh, speeding up the local development. https://github.com/ArnaudBarre/eslint-plugin-react-refresh https://github.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#consistent-components-exports
Several files had the .tsx extension despite not containing any JSX.
rakyi
force-pushed
the
eslint-plugin-react-refresh
branch
from
16df04b to
b11707e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add eslint-plugin-react-refresh
Fast Refresh is a feature that lets you edit React components in a
running application without losing their state. It is similar to an old
feature known as "hot reloading", but Fast Refresh is more reliable and
officially supported by React.
Vite already supports Fast Refresh, but it works only under specific
conditions. This ESlint plugin helps us write components in a way that
ensures they can be reloaded using Fast Refresh. We don't enable it for
directories containing mostly class components, since it doesn't work
for them.
As part of this change I fixed the linter errors by refactoring the
code, which means now many more components will be working with Fast
Refresh, speeding up the local development.
https://github.com/ArnaudBarre/eslint-plugin-react-refresh
https://github.com/vitejs/vite-plugin-react/tree/main/packages/plugin-react#consistent-components-exports
Rename adminSiteServer files from .tsx to .ts
Several files had the .tsx extension despite not containing any JSX.