✨ deduplicate sources tab by label / TAS-793 #4421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 4 (2abfb5) ❌ Edited: 2025-01-09 17:18:28 UTC |
sophiamersmann
force-pushed
the
deduplicate-line-labels
branch
from
1763dbe to
16aefe0
Compare
sophiamersmann
force-pushed
the
deduplicate-sources-tabs
branch
from
f14f80e to
3ef02e0
Compare
sophiamersmann
force-pushed
the
deduplicate-line-labels
branch
from
16aefe0 to
9cce322
Compare
sophiamersmann
force-pushed
the
deduplicate-sources-tabs
branch
from
3ef02e0 to
56f5a7e
Compare
sophiamersmann
force-pushed
the
deduplicate-sources-tabs
branch
from
56f5a7e to
1058a78
Compare
sophiamersmann
changed the title
danyx23
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deduplicates the sources based on their label.
In rare cases, authors hack line charts to show breaks between line segments. They do so by using the same indicator multiple times. One side effect is that Grapher then shows a source tab for every imported indicator – even when their identical.
For scatter plots like this one that use the same indicator twice with different target years, the sources also appear twice.
I can't think of a situation where the tab label would be exactly the same, but we'd still want to show both tabs. So I decided to deduplicate by label. It would be safer to deduplicate on all of the content, but that seems wasteful.
SVG testet differences come from a previous PR.
Link: https://ourworldindata.org/explorers/poverty-explorer?facet=none&country=BOL~DEU~ALB&Indicator=Share+in+poverty&Poverty+line=%242.15+per+day%3A+International+Poverty+Line&Household+survey+data+type=Show+data+from+both+income+and+consumption+surveys&Show+breaks+between+less+comparable+surveys=true
This is part 2 of 2 in a stack made with GitButler: