✨ prefer smallFilename for data insights

[ikesau]

Resolves #4416

Changes:

• Adds a documentType property to the DocumentContext object
• Adds a codepath in Image.tsx to always use the smallFilename (if defined) if the image is being used in a data insight
• Updates the latest data insight block with a similar prefer-small logic
• Updates CSS (one small update remains, pending clarification from Marwa)

[owidbot]

Quick links (staging server):

Site Dev	Site Preview	Admin	Wizard	Docs

Login: ssh owid@staging-site-single-image-data-insights

• Site-screenshots: https://github.com/owid/site-screenshots/compare/single-image-data-insights
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/single-image-data-insights

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-15 00:12:53 UTC
Execution time: 1.21 seconds

[rakyi]

Just to confirm, we want to retroactively apply this change for all existing data insights, right?

For the logic, one of my favorite maxims of software development is "I don't know, I don't wanna know". It would be better if the Image didn't know where it is used, and instead we passed in a prop (preferSmall?) to achieve the same effect. We always know we are in a data insight at the call site after all, right? That way it will stay more decoupled.

[ikesau]

Yup, retroactive (hence why I contemplated this solution, but decided it was too much work for this somewhat-experimental project (even though I feel 80% confident that we'll stick with single-image data insights))

I like that maxim, and I feel you on the context codepath thing. preferSmallfilename is just such a stupid prop that we'd never use anywhere else. Prop-drilling it from DataInsightBody down to ArticleBlocks down to ArticleBlock down to Image seemed a little bit worse.

If you feel more strongly about it than I do, I'll gladly change it, though 🙂

[rakyi]

I think adding it to the image block(s) in content body would be probably nicer than prop drilling it at the top level. But I prefer either of those to the context. So please change it, unless there is something problematic lurking there that we missed.

[ikesau]

@rakyi changed 🙂

[rakyi]

Great, thank you!