enhance(homepage): better socials block on homepage #4472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-21 16:26:11 UTC |
ikesau
reviewed
Jan 21, 2025
site/gdocs/pages/Homepage.scss
Outdated
| // A bunch of magic numbers! | ||
| // The 40% ensures that auto-fit creates at most 2 columns. We can't use the more sensible 50%, because grid gaps need to be accounted for. | ||
| // The 120px ensures that a column is at least 120px wide, i.e. we only get 2 columns if the container is at least 240px (+gap) wide. | ||
| grid-template-columns: repeat(auto-fit, minmax(max(40%, 120px), 1fr)); |
There was a problem hiding this comment.
Damn, this took me a while to understand too 😅
We have a --grid-gap variable to make this slightly less magic, and you could add some other element-scoped variables, too, maybe? It might make it a bit more readable (though I'd bet this code won't be touched again for years, now 😂)
--half-width: calc(50% - var(--grid-gap) / 2);
--min-column-width: max(var(--half-width), 120px);
grid-template-columns: repeat(
auto-fit,
minmax(var(--min-column-width), 1fr)
);
ikesau
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, I'll admit it, I spent way too much time to fix this small little annoyance 😬 But I learned a bit about grid layouts on the way, soo... :)
The video shows the two things that have changed:
CleanShot.2025-01-21.at.17.11.23.mp4