Add Sentry to Cloudflare Functions #4487
Open
+120
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-01-24 14:36:22 UTC |
rakyi
force-pushed
the
sentry-cloudflare
branch
5 times, most recently
from
6e91c66 to
7a63d30
Compare
rakyi
force-pushed
the
sentry-cloudflare
branch
from
7a63d30 to
f0e5a70
Compare
rakyi
force-pushed
the
sentry-cloudflare
branch
from
f0e5a70 to
4b30263
Compare
rakyi
commented
Jan 24, 2025
| @@ -15,7 +21,7 @@ GRAPHER_CONFIG_R2_BUCKET_FALLBACK_PATH = "v1" | |||
| [env.preview.vars] | |||
| MAILGUN_DOMAIN = "mg.ourworldindata.org" | |||
| SLACK_ERROR_CHANNEL_ID = "C016H0BNNB1" | |||
| ENV = "preview" | |||
| ENV = "staging" | |||
There was a problem hiding this comment.
To be consistent with other ENV settings.
* We added the latest @sentry/cloudflare so this is to avoid duplicate transitive packages with different versions. * @sentry/vite-plugin is independent of that, but we might update it just as well.
rakyi
force-pushed
the
sentry-cloudflare
branch
from
924b190 to
cdc679f
Compare
ikesau
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Nice! It's a shame we lose the source map 😢
I tried visiting https://sentry-cloudflare.owid.pages.dev/deleted/deleted-article but it didn't seem to log the error in Sentry. Did you have to do something else to get it to log?
|
I added a temporary code that raised the error on that URL to test that the integration works, and then I removed it. You could do the same, if you want to double-check. |
ikesau
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I set the
SENTRY_DSNin staging wrangler .dev.vars and in the CF dashboard as secrets for both production and preview. See the testing issue.Resolves #4187