Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 hide footer when printing, better article layout #4498

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Jan 28, 2025

Still pretty glitchy on non-chrome browsers - this is just a best-effort attempt, timeboxed to an hour of tinkering. Feel free to add patches to the branch if you get nerd-sniped, but I recommend approving and running away as fast as you can 😁

Screen.Recording.2025-01-28.at.17.50.59.mov

@owidbot
Copy link
Contributor

owidbot commented Jan 28, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-print-layout

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-28 23:08:59 UTC
Execution time: 1.13 seconds

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, definitely an improvement! I only got very slightly nerdsniped into hiding the cookie banner in print.

I wonder if it would make sense to have grid-print-12 or so utility classes, similar to how we have these for various breakpoints? But maybe it's also quite some effort to make sure these are actually used, then?

@ikesau ikesau merged commit df7af51 into master Jan 29, 2025
25 checks passed
@ikesau ikesau deleted the print-layout branch January 29, 2025 14:50
@ikesau
Copy link
Member Author

ikesau commented Jan 29, 2025

I don't think any work on this will "make sense" in terms of investment:reward 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants