Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Footer rework #4512

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

🎉 Footer rework #4512

wants to merge 3 commits into from

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Jan 31, 2025

Resolves #4430

Changes

  • Updates affiliate logos (Oxford Martin School, Oxford University, GCDL, Y Combinator) to SVG
  • Separates OMS from Oxford University in site nav (approved by Este)
  • Rewrites site footer to conform to new Figma design
  • Deletes .owid-layout CSS utils that were only being used in the old footer
site.footer.rework.mp4

@ikesau ikesau requested a review from rakyi January 31, 2025 20:45
@ikesau ikesau self-assigned this Jan 31, 2025
ikesau
ikesau commented Jan 31, 2025
View reviewed changes
site/SiteLogos.scss
@@ -33,14 +33,9 @@
opacity: initial;
}
}
.oxford-logo img {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The viewboxes in the SVGs are set such that the borders in each graphic will all be flush when the SVG elements are the same height.

ikesau
ikesau commented Jan 31, 2025
View reviewed changes
site/css/footer.scss
@@ -1,131 +1,183 @@
.site-footer {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rewrote this from scratch so if you want to check this out I would just look at the new file without the diff.

@owidbot
Copy link
Contributor

owidbot commented Jan 31, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-footer-rework

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-31 21:14:30 UTC
Execution time: 1.16 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakyi rakyi Awaiting requested review from rakyi

Assignees

@ikesau ikesau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cycle 2025.1: footer updates
2 participants
@ikesau @owidbot