Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ make text outline work in Figma #4538

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Feb 6, 2025

Using ems for the outline's width doesn't work in Figma.
@sophiamersmann sophiamersmann force-pushed the figma-text-outline branch 2 times, most recently from 228fb9c to f9e8451 Compare February 6, 2025 15:18
@sophiamersmann sophiamersmann marked this pull request as ready for review February 6, 2025 15:19
@owidbot
Copy link
Contributor

owidbot commented Feb 6, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-figma-text-outline

SVG tester:

Number of differences (default views): 2005 (1aa271) ❌
Number of differences (all views): 1065 (6992d8) ❌

Edited: 2025-02-06 15:43:24 UTC
Execution time: 1.19 seconds

Base automatically changed from figma-scatter-plots to master February 6, 2025 16:16
@sophiamersmann sophiamersmann merged commit 7bdc595 into master Feb 6, 2025
21 checks passed
@sophiamersmann sophiamersmann deleted the figma-text-outline branch February 6, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants