[testing] Allow to lock a file without the lock being killed at the end of the request #22823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @jancborchardt and @LukasReschke to be potential reviewers |
3 tasks
nickvergessen
force-pushed
the
add-fake-locking-to-testing-app
branch
2 times, most recently
from
3c53a14 to
59fd288
Compare
|
@PVince81 @icewind1991 please review, so we can finally have smashbox locking tests: owncloud/smashbox#134 |
|
👍 |
|
@DeepDiver1975 can we have this testing only PR? |
nickvergessen
force-pushed
the
add-fake-locking-to-testing-app
branch
from
59fd288 to
1479f68
Compare
|
Bump, @DeepDiver1975 please review and merge ;) |
|
@nickvergessen is the "testing" app removed from the tarballs at build time ? |
|
Yes it is already since 8.2 |
|
@icewind1991 @SergioBertolinSG second review ? |
|
👍 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.