Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Add tests for issue-ocis-1747 #38488

Merged
merged 1 commit into from
Mar 11, 2021
Merged

[tests-only] Add tests for issue-ocis-1747 #38488

merged 1 commit into from
Mar 11, 2021

Conversation

swoichha
Copy link
Contributor

Description

This PR modifies tests for tus upload OPTIONS request as per owncloud/ocis#1747

Related Issue

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@swoichha swoichha self-assigned this Mar 10, 2021
@swoichha swoichha mentioned this pull request Mar 10, 2021
Closed
Talank
Talank reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dpakach
dpakach reviewed Mar 10, 2021
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@swoichha swoichha requested a review from individual-it March 10, 2021 09:31
@swoichha swoichha force-pushed the tusTests-issue-1747 branch from 916995e to bf339a2 Compare March 10, 2021 10:44
individual-it
individual-it approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure the commit id is updated in ocis and cs3org/reva repo

@swoichha swoichha force-pushed the tusTests-issue-1747 branch from bf339a2 to a35ddbb Compare March 11, 2021 03:34
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swoichha swoichha merged commit 3aaf7bf into master Mar 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the tusTests-issue-1747 branch March 11, 2021 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Talank Talank Talank left review comments

@dpakach dpakach dpakach left review comments

@individual-it individual-it individual-it approved these changes

@jasson99 jasson99 Awaiting requested review from jasson99

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@swoichha swoichha

Labels
3 - To Review QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swoichha @individual-it @dpakach @Talank