Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Update web to v4.3.0 #2589

Merged
merged 5 commits into from
Oct 7, 2021
Merged

[full-ci] Update web to v4.3.0 #2589

merged 5 commits into from
Oct 7, 2021

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Oct 7, 2021

Description

Update web to v4.3.0

Related Issue

How Has This Been Tested?

  • full ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

wkloucek
wkloucek approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@phil-davis
Copy link
Contributor

@kulmann this needs some line number changes in expected-failures. Do you want me to push a commit for that? Or are you already looking?

@kulmann
Copy link
Contributor Author

kulmann commented Oct 7, 2021

@kulmann this needs some line number changes in expected-failures. Do you want me to push a commit for that? Or are you already looking?

Oh that would be nice if you could take a look. Thank you @phil-davis !

@kulmann kulmann mentioned this pull request Oct 7, 2021
Closed
24 tasks
phil-davis
phil-davis reviewed Oct 7, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accounts and settings UI tests are failing.
In web, nightwatch was bumped to 1.7.11 in PR owncloud/web#5820 and nothing special was needed for the tests to keep passing.

So maybe there is some other reason that these "local" test for accounts and settings are failing in this PR?

settings/package.json
"nightwatch": "1.5.1",
"nightwatch": "1.7.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://drone.owncloud.com/owncloud/ocis/7028/52/7
The settingsUITests are not working. Maybe that is related to this change?

accounts/package.json
"nightwatch": "1.5.1",
"nightwatch": "1.7.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://drone.owncloud.com/owncloud/ocis/7028/51/6
The accountsUITests are not working. Maybe that is related to this change?

@phil-davis
Copy link
Contributor

@kulmann the accounts and settings UI tests are failing. I am offline for a while, and I don't immediately know how to fix it. Anyone feel free to push a fix!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann
Copy link
Contributor Author

kulmann commented Oct 7, 2021

@kulmann the accounts and settings UI tests are failing. I am offline for a while, and I don't immediately know how to fix it. Anyone feel free to push a fix!

Needed to downgrade node-fetch to v2.

@phil-davis phil-davis merged commit 3f01f0c into master Oct 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-web-4.3.0 branch October 7, 2021 16:10
ownclouders pushed a commit that referenced this pull request Oct 7, 2021
@phil-davis
commit 3f01f0c
b63bd31 
Merge: 47abbde 056d594
Author: Phil Davis <[email protected]>
Date:   Thu Oct 7 21:55:19 2021 +0545

    Merge pull request #2589 from owncloud/update-web-4.3.0

    [full-ci] Update web to v4.3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@wkloucek wkloucek wkloucek approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@lookacat lookacat Awaiting requested review from lookacat

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kulmann @phil-davis @wkloucek @pascalwengerter