Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(password-protected-folders): add permissions dropdown #12141

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Jan 28, 2025

Description

We've added the permissions dropdown into the create password protected folder dialog. Users can now decide what permissions they would like to add to the folder. Permissions are matching folder public link permissions.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: extended unit tests to include permissions change
  • test case 2: create folder with set permission

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Jan 28, 2025
@LukasHirt LukasHirt self-assigned this Jan 28, 2025
@LukasHirt LukasHirt force-pushed the feat/psec-permissions branch from 609fb25 to 58cefd9 Compare January 30, 2025 08:43
Show public link permissions dropdown in the create folder modal.
@LukasHirt LukasHirt force-pushed the feat/psec-permissions branch from 58cefd9 to 4617080 Compare January 30, 2025 08:43
@LukasHirt LukasHirt marked this pull request as ready for review January 30, 2025 08:44
@LukasHirt LukasHirt requested a review from saw-jan January 30, 2025 08:44
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt merged commit 0ac580d into master Jan 30, 2025
4 checks passed
@LukasHirt LukasHirt deleted the feat/psec-permissions branch January 30, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants