Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Github actions rebuild web UI on push to web-src #1670

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Conversation

ejurgensen
Copy link
Member

@hacketiwack I think it would be good if Github actions was used to automatically rebuild the web UI whenever a change is pushed to web-src. Thus, there is no relying on the build on a local machine, and the rebuilt UI can be kept out of a PR.

Let me know if you have any concerns about this.

@hacketiwack
Copy link
Collaborator

@ejurgensen, this situation bothered me for long and I'm glad that you tackled it.

I'm OK for this temporary solution.

But I have a guiding principle that says that no generated files must be placed in the source control repository.
Indeed, the build script of OwnTone, must include the generation of htdocs as well.
This would solve this work item as well.

I tried to fiddle around with the Makefile some months ago to not have to store the htdocs in the SCM.
But I wasn't successful at the time at finding a good example on how to do it.
Would it be possible for you to include the build of the Web UI within the Makefile?
Otherwise, I will continue my research.

Thanks in advance.

@ejurgensen ejurgensen merged commit 9e9dc27 into master Oct 22, 2023
4 checks passed
@ejurgensen
Copy link
Member Author

But I have a guiding principle that says that no generated files must be placed in the source control repository.
Indeed, the build script of OwnTone, must include the generation of htdocs as well.

Yes, I agree, but it is difficult in practice. You may have seen PR #1439 where chme worked on this. One of the obstacles is that the node build needs to pull in resources from the internet. This doesn't work well with some package builders, and maybe it is also against Debian policies. I guess it also makes the build non-deterministic by nature, which is also against Debian policies, as I recall.

Would it be possible for you to include the build of the Web UI within the Makefile?

chme's PR does do this via ("make web"), so I can try to rebase it and merge it. Maybe it also needs some dusting off. But it will just mean that the assets can be built with "make web", it won't solve the issue of having generated files in the source.

@ejurgensen ejurgensen deleted the gh_build_webui branch November 6, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants