New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Ensure current lyric is centered #1687

Merged

hacketiwack merged 1 commit into owntone:master from X-Ryl669:FixCenterLyricPos

Nov 21, 2023

Contributor

X-Ryl669 commented Nov 21, 2023 •

edited

Loading

Fix #1686's remark.

I have added a spacing items in the lyrics list for the start and end of the list, but forgot to account for them in the auto scroll function. This restores the previous behavior of keeping the actual lyric centered.

Hopefully, this will end the lyrics integration work, as I think the status is now complete.


          [web] Ensure current lyric is centered

3fc1493

Collaborator

hacketiwack commented Nov 21, 2023

That's indeed excellent! It works perfectly.

hacketiwack closed this

Collaborator

hacketiwack commented Nov 21, 2023

Thanks

hacketiwack reopened this

hacketiwack approved these changes

View reviewed changes

hacketiwack merged commit 2f0e19c into owntone:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet