fix: fix extends BindingPattern in d.ts

oxc-project · Feb 8, 2025 · 8545cac · 8545cac
1 parent a601a15
commit 8545cac
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/npm/oxc-types/types.d.ts b/npm/oxc-types/types.d.ts
@@ -483,9 +483,12 @@ export interface CatchClause extends Span {
   body: BlockStatement;
 }
 
-export interface CatchParameter extends Span, BindingPattern {
-  type: 'CatchParameter';
-}
+export type CatchParameter =
+  & ({
+    type: 'CatchParameter';
+  })
+  & Span
+  & BindingPattern;
 
 export interface DebuggerStatement extends Span {
   type: 'DebuggerStatement';

diff --git a/tasks/ast_tools/src/generators/typescript.rs b/tasks/ast_tools/src/generators/typescript.rs
@@ -224,7 +224,8 @@ fn generate_ts_type_def_for_struct_field<'s>(
             }
         }
 
-        if field_type_name.contains('|') {
+        // need `type` instead of `interface` when flattening BindingPattern
+        if field_type_name.contains('|') || field_type_name == "BindingPattern" {
             *output_as_type = true;
         }
         extends.push(field_type_name);