Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer): support TypeScript experimental decorator #8614

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 20, 2025

related: #4047
related: rolldown/rolldown#2296

THIS IS STILL UNDER DEVELOPMENT!!!

Copy link
Member Author

Dunqing commented Jan 20, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Jan 20, 2025
@Boshen
Copy link
Member

Boshen commented Jan 22, 2025

Can you make space for ecma decorators? i.e. name current decorator as LegacyDecorator.

Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #8614 will not alter performance

Comparing 01-20-feat_transformer_support_typescript_experimental_decorator (ae9612b) with main (b977678)

Summary

✅ 32 untouched benchmarks

@@ -0,0 +1,284 @@
//! Typescript Experimental Decorator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experimental has become confusing, let's not mention it except use the term legacy decorator (--experimentalDecorators) explicitly.

@Dunqing Dunqing force-pushed the 01-20-feat_transformer_support_typescript_experimental_decorator branch from 386e3d6 to 115bbda Compare January 22, 2025 14:23
@Dunqing Dunqing changed the base branch from main to 01-22-feat_ast_derive_clone_and_copy_for_templateelement_and_templateelementvalue January 22, 2025 14:24
overlookmotel pushed a commit that referenced this pull request Jan 22, 2025
@overlookmotel overlookmotel force-pushed the 01-22-feat_ast_derive_clone_and_copy_for_templateelement_and_templateelementvalue branch 2 times, most recently from e2bb198 to b73f8a8 Compare January 22, 2025 15:57
@overlookmotel overlookmotel force-pushed the 01-20-feat_transformer_support_typescript_experimental_decorator branch from 97e7f9c to 4ac37a4 Compare January 22, 2025 15:57
@Dunqing Dunqing force-pushed the 01-22-feat_ast_derive_clone_and_copy_for_templateelement_and_templateelementvalue branch from b73f8a8 to f0ed208 Compare January 22, 2025 16:21
@Dunqing Dunqing force-pushed the 01-20-feat_transformer_support_typescript_experimental_decorator branch from 4ac37a4 to 318f4bc Compare January 22, 2025 16:22
@Dunqing Dunqing force-pushed the 01-22-feat_ast_derive_clone_and_copy_for_templateelement_and_templateelementvalue branch from f0ed208 to d287a61 Compare January 23, 2025 03:08
@Dunqing Dunqing force-pushed the 01-20-feat_transformer_support_typescript_experimental_decorator branch from 318f4bc to 69ed340 Compare January 23, 2025 03:08
@Boshen Boshen changed the base branch from 01-22-feat_ast_derive_clone_and_copy_for_templateelement_and_templateelementvalue to graphite-base/8614 January 24, 2025 03:53
Boshen pushed a commit that referenced this pull request Jan 24, 2025
…alue` (#8658)

In #8614, we need to duplicate the same template literal, and derive `Copy` and `Clone` to avoid using `CloneIn`.
@github-actions github-actions bot added the A-ast Area - AST label Jan 24, 2025
Boshen pushed a commit that referenced this pull request Jan 24, 2025
…alue` (#8658)

In #8614, we need to duplicate the same template literal, and derive `Copy` and `Clone` to avoid using `CloneIn`.
@Boshen Boshen force-pushed the 01-20-feat_transformer_support_typescript_experimental_decorator branch from 9efa0dc to e37cb67 Compare January 24, 2025 04:04
@Boshen Boshen force-pushed the graphite-base/8614 branch from d287a61 to 233dc07 Compare January 24, 2025 04:04
@Boshen Boshen changed the base branch from graphite-base/8614 to main January 24, 2025 04:05
@Boshen Boshen force-pushed the 01-20-feat_transformer_support_typescript_experimental_decorator branch from e37cb67 to 013ddd8 Compare January 24, 2025 04:05
@Dunqing Dunqing force-pushed the 01-20-feat_transformer_support_typescript_experimental_decorator branch from 013ddd8 to 16df060 Compare January 24, 2025 04:12
@Dunqing Dunqing force-pushed the 01-20-feat_transformer_support_typescript_experimental_decorator branch from 1104e05 to ae9612b Compare January 24, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants