Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(minifier): move conditional assignment to minimize_conditions #8669

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 23, 2025

No description provided.

@github-actions github-actions bot added A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 23, 2025
Copy link
Member Author

Boshen commented Jan 23, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

graphite-app bot commented Jan 23, 2025

Merge activity

@Boshen Boshen force-pushed the 01-23-refactor_minifier_move_conditional_assignment_to_minimize_conditions_ branch from a811d10 to 13e4a45 Compare January 23, 2025 04:42
@graphite-app graphite-app bot merged commit 13e4a45 into main Jan 23, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-23-refactor_minifier_move_conditional_assignment_to_minimize_conditions_ branch January 23, 2025 04:47
Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #8669 will improve performances by 13.57%

Comparing 01-23-refactor_minifier_move_conditional_assignment_to_minimize_conditions_ (13e4a45) with main (ba201a6)

Summary

⚡ 1 improvements
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
minifier[antd.js] 168.6 ms 148.4 ms +13.57%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-minifier Area - Minifier C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant