Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): correct the is_reference_to_global_variable #8920

Conversation

shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Feb 6, 2025

          Can you do a fix PR for the global reference problem (semantic + `globals`) to reduce the changes of this PR?

Originally posted by @Boshen in #8845 (review)

Copy link

graphite-app bot commented Feb 6, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Feb 6, 2025
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #8920 will not alter performance

Comparing shulaoda:fix/use-correct-is-reference-to-global-variable (01ce867) with main (515eb52)

Summary

✅ 33 untouched benchmarks

@Boshen Boshen requested a review from Sysix February 6, 2025 15:02
@shulaoda shulaoda force-pushed the fix/use-correct-is-reference-to-global-variable branch from 1f00589 to 01ce867 Compare February 7, 2025 09:55
@Sysix Sysix merged commit 44d985b into oxc-project:main Feb 7, 2025
26 checks passed
@shulaoda shulaoda deleted the fix/use-correct-is-reference-to-global-variable branch February 7, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants