Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks/coverage): estree test262 conformance runner #8946

Merged
merged 18 commits into from
Feb 7, 2025

Conversation

hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Feb 7, 2025

Related #8630

I updated Boshen's branch https://github.com/oxc-project/oxc/compare/estree. Instead of creating a 2nd serializer to strip ts ast suggested by overlookmotel, for now I'm stripping extra properties on oxc side before comparing acorn output, which allows easier diff and usable coverage report at this current state.

Copy link

graphite-app bot commented Feb 7, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Feb 7, 2025
@hi-ogawa hi-ogawa marked this pull request as ready for review February 7, 2025 08:04
Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing fields from Oxc AST which don't exist in Acorn AST is not 100% accurate - we may be including spurious fields which aren't related to TS, and we won't catch them this way. But it's a very good place to start!

Thank you.

@overlookmotel overlookmotel merged commit 0e2dd19 into oxc-project:main Feb 7, 2025
15 checks passed
@overlookmotel
Copy link
Contributor

overlookmotel commented Feb 7, 2025

I just tried it out. Wow it's really slow. Damn you serde!

A custom serializer which removes the TS-related fields will speed it up, but in meantime it's great to have this working, so we can make progress.

I've made some changes to acorn-test262 today, and am updating to latest commits (#8958).

@hi-ogawa hi-ogawa deleted the test-estree-compat branch February 8, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants