fix(tasks/coverage): convert spans to UTF16 in estree conformance runner #8965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 7, 2025
Merge activity
|
…ner (#8965) In ESTree conformance runner, convert `Span` to UTF16 offsets before comparing to Acorn. This removes a lot of noise from the diffs (and seems to speed up the conformance runner a lot too).
graphite-app
bot
force-pushed
the
02-07-chore_deps_bump_test262_and_acorn-test262_conformance_fixtures
branch
from
69ba80c to
409385d
Compare
graphite-app
bot
force-pushed
the
02-07-fix_tasks_coverage_convert_spans_to_utf16_in_estree_conformance_runner
branch
from
ada708b to
f978dd8
Compare
Base automatically changed from
02-07-chore_deps_bump_test262_and_acorn-test262_conformance_fixtures
to
main
February 8, 2025 14:58
graphite-app
bot
deleted the
02-07-fix_tasks_coverage_convert_spans_to_utf16_in_estree_conformance_runner
branch
Dunqing
pushed a commit
that referenced
this pull request
Feb 10, 2025
…ner (#8965) In ESTree conformance runner, convert `Span` to UTF16 offsets before comparing to Acorn. This removes a lot of noise from the diffs (and seems to speed up the conformance runner a lot too).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ESTree conformance runner, convert
Spanto UTF16 offsets before comparing to Acorn. This removes a lot of noise from the diffs (and seems to speed up the conformance runner a lot too).