Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ast/estree): bump acorn-test262 submodule #9047

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 11, 2025

Bump acorn-test262 submodule to integrate commit oxc-project/acorn-test262@dcb0700 which fixes Acorn's output for 1 of the ESTree conformance tests which was previously failing.

The problem on that test case wasn't Oxc, the problem was that we were running Acorn with the wrong options.

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Feb 11, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 11, 2025 18:35
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 11, 2025
Copy link
Contributor Author

overlookmotel commented Feb 11, 2025

Merge activity

  • Feb 11, 1:36 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 11, 1:38 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 11, 1:42 PM EST: A user merged this pull request with the Graphite merge queue.

Bump `acorn-test262` submodule to integrate commit oxc-project/acorn-test262@dcb0700 which fixes Acorn's output for 1 of the ESTree conformance tests which was previously failing.

The problem on that test case wasn't Oxc, the problem was that we were running Acorn with the wrong options.
@graphite-app graphite-app bot force-pushed the 02-11-test_ast_estree_bump_acorn-test262_submodule branch from 551e235 to 4e4a2fe Compare February 11, 2025 18:38
@graphite-app graphite-app bot merged commit 4e4a2fe into main Feb 11, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 02-11-test_ast_estree_bump_acorn-test262_submodule branch February 11, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant