Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVHS and CVBS improvements #124

Closed
wants to merge 8 commits into from
Closed

SVHS and CVBS improvements #124

wants to merge 8 commits into from

Conversation

Stefan-Olt
Copy link

Implemented a CVBS automatic gain adjustment / clamping:

  • It will take the sync and the black level after time-base-correction as reference
  • It will calculate the median of all blank and sync levels of all lines (except top/bottom) to calculate the gain for the entire field
  • The gain is averaged over time
  • It will clamp based an on the median of the blank level of the line and 2 last and 2 next lines (to compensate for dropouts)
  • The sync/blank levels of the last field are used for sync detection of the next field
  • Added options: Enable this functionality, set gain multiplier, set fixed gain, set gain average speed

Improved S-VHS sub de-emphasis

  • Added second linear de-emphasis
  • Adjusted linear & non-linear sub de-emphasis values to match the spec
  • Eyeballed de-emphasis values to reduce phase errors as much as possible

Filter-plot:

  • Removed old SVHS-specific experiment
  • Added reference values to plot (only S-VHS at the moment, but designed for other formats to be added, currently incorrect as only non-linear de-emphasis is plotted)
  • Added QSplitter to make image and plot division adjustable with mouse

@harrypm harrypm added enhancement New feature or request Signal Processing Related to decodes signal processing and filtering code. labels Jan 22, 2024
@Stefan-Olt
Copy link
Author

I tested on another sample, SVHS sync problems can dramatically increase, therefore I'm closing the pull request

@Stefan-Olt Stefan-Olt closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Signal Processing Related to decodes signal processing and filtering code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants