trust: Prevent trust module being loaded by proxy module #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueno
force-pushed
the
wip/dueno/disable-trust-in-proxy
branch
11 times, most recently
from
cc36198 to
9ddd1b8
Compare
ueno
changed the title
p11_kit_iter_add_filter() takes the ownership of given attributes. Spotted by address sanitizer.
Otherwise, when the proxy module were registerd in NSS database, the trust module would be loaded twice and degrade search performance.
Currently it only checks that "disable-in: p11-kit-proxy" properly prevents the trust module being loaded by the proxy module.
ueno
force-pushed
the
wip/dueno/disable-trust-in-proxy
branch
from
9ddd1b8 to
a31f8de
Compare
tomato42
reviewed
Apr 10, 2018
.travis.yml
Outdated
| @@ -22,26 +22,34 @@ before_install: | |||
| - docker exec $CONTAINER dnf -y install libasan libubsan | |||
| - docker exec $CONTAINER dnf -y install clang-analyzer | |||
| - docker exec $CONTAINER dnf -y install mingw64-gcc mingw64-libffi mingw64-libtasn1 wine | |||
| - docker exec $CONTAINER dnf -y install opensc openssl | |||
There was a problem hiding this comment.
why not all installations are done at the same time? wouldn't it make them faster?
There was a problem hiding this comment.
That's a good point; I arranged the dnf install invocation in 05c257e.
tomato42
approved these changes
Apr 10, 2018
|
Thank you for the review! |
|
How is the trust module otherwise loaded? It it automatically loaded by some other mechanism, or are users expected to register it explicitly in the nssdb separate from the proxy module (which is automatically registered.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, when the proxy module were registered in NSS database, the
trust module would be loaded twice and affect search performance.