Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure fewer messages can be provided than r values #34

Open
wants to merge 1 commit into
base: feature/optimized-sigpoint-computation
Choose a base branch
from

Conversation

matthewjablack
Copy link

This PR adds the ability to pass in fewer messages than r values to CreateCetAdaptorSignatures and VerifyCetAdaptorSignatures to allow for fewer r values to be used than specified

Copy link
Collaborator

@k-matsuzawa k-matsuzawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the need for OutOfRange guards.

Thanks!

src/cfddlc_transactions.cpp Show resolved Hide resolved
src/cfddlc_transactions.cpp Show resolved Hide resolved
Copy link
Collaborator

@Tibo-lg Tibo-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry small nits. Also if you can squash your commits then it will be ready to be merged.

src/cfddlc_transactions.cpp Outdated Show resolved Hide resolved
src/cfddlc_transactions.cpp Outdated Show resolved Hide resolved
Add ability to pass in less messages than r values for a particular CET
Add OutOfRange guard to ensure r values length greater or equal to messages length
Add CfdException to CreateCetAdaptorSignatures and VerifyCetAdaptorSignatures if r values length is less than messages length
Add tests for AdaptorSigMultipleNoncesWithFewerMessagesThanNonces and AdaptorSigMultipleNoncesWithMoreMessagesThanNoncesFails
@matthewjablack matthewjablack force-pushed the feature/optimized-sigpoint-computation branch from 8a7e597 to b1064b0 Compare February 19, 2021 08:07
@matthewjablack
Copy link
Author

Fixed small nits and squashed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants