Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for ordinals #175

Merged
merged 4 commits into from
Nov 24, 2023

Conversation

sosaucily
Copy link
Contributor

No description provided.

docs/Ordinal.md Outdated Show resolved Hide resolved
docs/Ordinal.md Outdated Show resolved Hide resolved
docs/Ordinal.md Outdated Show resolved Hide resolved
docs/Ordinal.md Outdated Show resolved Hide resolved
docs/Ordinal.md Outdated Show resolved Hide resolved
docs/Ordinal.md Outdated Show resolved Hide resolved
docs/Ordinal.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Tibo-lg Tibo-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly fine with it now, just a couple of suggestions.

docs/Ordinal.md Outdated Show resolved Hide resolved
docs/Ordinal.md Outdated Show resolved Hide resolved
sosaucily and others added 2 commits November 23, 2023 09:08
Co-authored-by: Thibaut Le Guilly <[email protected]>
Co-authored-by: Thibaut Le Guilly <[email protected]>
@sosaucily
Copy link
Contributor Author

Can commit suggestions directly from the github UI!

Copy link
Contributor

@Tibo-lg Tibo-lg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Tibo-lg Tibo-lg merged commit 8519abd into p2pderivatives:feature/ordinals Nov 24, 2023
60 checks passed
@yancyribbens
Copy link
Contributor

It looks like the term gas fee is still being used. Is this intentional?

@Tibo-lg
Copy link
Contributor

Tibo-lg commented Nov 27, 2023

It looks like the term gas fee is still being used. Is this intentional?

I don't see it personally

@yancyribbens
Copy link
Contributor

oops, I must have been looking at an outdated diff.

@sosaucily
Copy link
Contributor Author

oops, I must have been looking at an outdated diff.

Thanks for taking the time to give a review @yancyribbens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants